dimanche 27 août 2017

Is this design of a Spring JPA DAO bad or improper?

I have been working to generalize the methods of the DAO for a project using Spring, JPA and Hibernate. However, I am still very much learning Spring, Java, and coding in general.

Is the below design bad or perfectly fine? Is there a better way to accomplish the same thing? Any advice would be greatly appreciated.

I have simplified the class:

@Repository
public class TestRepository
{
    @PersistenceContext
    private EntityManager entityManager;

    public List<?> getListResults(Class<?> dtoClass, String sqlString)
    {        
        List<?> returnList = null;

        Query query = entityManager.createNativeQuery(sqlString, dtoClass);

        try
        {
            returnList = (List<?>) query.getResultList(); 
        }
        catch (Exception e)
        {

        }

        return returnList;
    } 
}

Aucun commentaire:

Enregistrer un commentaire