I have the following codes, I think the content is too large and I am deeply think about how to refactor it, may someone has good advice to refactor it ?
List<AccountEntity> fillNameAccounts = agentDao.getAgentListByIds(accountIdList);
for (T bean : results)
{
for (AccountEntity entity : fillNameAccounts)
{
String chineseName = entity.getChineseName();
String firstName = entity.getFirstName();
String fillName = StringUtils.isBlank(chineseName) ? firstName : chineseName;
String entityId = entity.getId().toString();
if (bean instanceof AgentPostResponseBean)
{
if (StringUtils.equals(((AgentPostResponseBean) bean).getParentId(), entityId))
{
((AgentPostResponseBean) bean).setParentName(fillName);
}
if (StringUtils.equals(((AgentPostResponseBean) bean).getPosterId(), entityId))
{
((AgentPostResponseBean) bean).setPosterName(fillName);
}
}
else if (bean instanceof ImportAgentPostResponseBean)
{
if (StringUtils.equals(((ImportAgentPostResponseBean) bean).getParentId(), entityId))
{
((ImportAgentPostResponseBean) bean).setParentName(fillName);
}
if (StringUtils.equals(((ImportAgentPostResponseBean) bean).getPosterId(), entityId))
{
((ImportAgentPostResponseBean) bean).setPosterName(fillName);
}
}
}
}
Thanks.
Aucun commentaire:
Enregistrer un commentaire