I use codeclimate to analyze statically my java code. The output says: Similar blocks of code found in 3 locations. Consider refactoring.
What could be the best way to refactor the following code without repeat myself and not losing the "code readability":
public String getString(String component, String key, String defaultValue) throws ConfigException {
try {
SingleRequestData config = clientRest.target(this.configServiceUrl).path(CONFIG_ENDPOINT).path(component)
.path(key).path(defaultValue).request(MediaType.APPLICATION_JSON).get(new GenericType<SingleRequestData>() {
});
logger.log(Level.INFO, "Fetched Remote config: {0}={1} for Component: {3}",
new Object[] { key, config.value, component });
return config.value;
} catch (Exception e) {
logger.log(Level.SEVERE, "{0} : {1}", new Object[] { e.getMessage(), ERROR_MESSAGE });
throw new ConfigException(e.getMessage() + " " + ERROR_MESSAGE, e.getCause());
}
}
@Override
public Integer getInteger(String component, String key, int defaultValue) throws ConfigException {
try {
String value = this.getString(component, key, String.valueOf(defaultValue));
return Integer.parseInt(value);
} catch (Exception e) {
logger.log(Level.SEVERE, e.getMessage(), e);
throw new ConfigException(e.getMessage(), e.getCause());
}
}
@Override
public Double getDouble(String component, String key, double defaultValue) throws ConfigException {
try {
String value = this.getString(component, key, String.valueOf(defaultValue));
return Double.parseDouble(value);
} catch (Exception e) {
logger.log(Level.SEVERE, e.getMessage(), e);
throw new ConfigException(e.getMessage(), e.getCause());
}
}
@Override
public Boolean getBoolean(String component, String key, boolean defaultValue) throws ConfigException {
try {
String value = this.getString(component, key, String.valueOf(defaultValue));
return Boolean.parseBoolean(value);
} catch (Exception e) {
logger.log(Level.SEVERE, e.getMessage(), e);
throw new ConfigException(e.getMessage(), e.getCause());
}
}
Thank you
Aucun commentaire:
Enregistrer un commentaire