lundi 5 juillet 2021

Refactor the code without if / else in PHP

How would you improve this code without using if / else?

public function modify()
{
    if ((in_array($this->model->getLocation(), $this->data['venue_locations']))) {

        if (array_key_exists('multiplier', $this->data)) {
            return $this->basePrice * $this->data['multiplier'];
        };

        if (array_key_exists('price', $this->data)) {
            return $this->data['price'];
        };
    }

    return $this->basePrice;
}

There are a lot of if conditions and looks bad and unprofessional.

Aucun commentaire:

Enregistrer un commentaire