mardi 10 janvier 2017

is that a good idea to use static variable in presenter that is declared in my Application cliass

Hi am using MVP pattern in my android application. I have some static method in application class that check for connectivity status.

public class AppModule extends Application {

public static boolean isNetworkAvailable() {
    ConnectivityManager connectivityManager
            = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
    NetworkInfo activeNetworkInfo = connectivityManager.getActiveNetworkInfo();
    return activeNetworkInfo != null && activeNetworkInfo.isConnected();
}

}

Am using that application level static method in presenter to check for internet connection as below.

public class ActivityWallPresenter {

private CreatrixTestCall creatrixTestCall;

@Inject
public ActivityWallPresenter(CreatrixTestCall creatrixTestCall) {
    this.creatrixTestCall = creatrixTestCall;
}

public void loadPosts(ActivityWallFragmentContract activityWallFragment) {
    this.fragmentContract = activityWallFragment;
    if (AppModule.isNetworkAvailable()) {
        callWeb();
    } else {
        //fragmentContract.onNetworkDisconnected();
    }
}

is that a good idea of calling a static method? suggest me any other approach if not.

Aucun commentaire:

Enregistrer un commentaire